Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operators: migrate envtests to Bazel #2252

Merged
merged 3 commits into from
Aug 17, 2023
Merged

operators: migrate envtests to Bazel #2252

merged 3 commits into from
Aug 17, 2023

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Aug 16, 2023 •
edited
Loading

Context

Proposed change(s)

  • operators: migrate envtests to Bazel

Additional info

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@netlify

This comment was marked as off-topic.

Sign in to view
@malt3 malt3 added the no changelog Change won't be listed in release changelog label Aug 16, 2023
@malt3 malt3 added this to the v2.11.0 milestone Aug 16, 2023
@malt3 malt3 force-pushed the feat/operators/bazelify-envtests branch 2 times, most recently from eb6870a to c7a64db Compare August 17, 2023 08:12
@malt3 malt3 force-pushed the feat/operators/bazelify-envtests branch from c7a64db to fc321ad Compare August 17, 2023 08:24
@malt3 malt3 marked this pull request as ready for review August 17, 2023 08:26
daniel-weisse
daniel-weisse approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@daniel-weisse daniel-weisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really judge the bazel parts, but lgtm

@malt3 malt3 merged commit 5cf2a59 into main Aug 17, 2023
6 checks passed
@malt3 malt3 deleted the feat/operators/bazelify-envtests branch August 17, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

@katexochen katexochen katexochen approved these changes

@elchead elchead Awaiting requested review from elchead elchead is a code owner

@thomasten thomasten Awaiting requested review from thomasten thomasten is a code owner

@derpsteb derpsteb Awaiting requested review from derpsteb derpsteb is a code owner

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@malt3 @katexochen @daniel-weisse